Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spring Cleanup] Refactor oauth2 webapp to remove Spring Framework Dependency #2675

Merged
merged 13 commits into from
Jan 23, 2025
Merged

[Spring Cleanup] Refactor oauth2 webapp to remove Spring Framework Dependency #2675

merged 13 commits into from
Jan 23, 2025

Conversation

lashinijay
Copy link
Contributor

@lashinijay lashinijay commented Jan 16, 2025 •
edited
Loading

Proposed changes in this pull request

  • $subject

Related Issue(s)

This PR includes the changes from the #2687 as well.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12812502295

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12812502295
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12821617859

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12821617859
Status: cancelled

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12822396715

nilasini
nilasini previously approved these changes Jan 17, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.45455% with 24 lines in your changes missing coverage. Please review.

Project coverage is 55.59%. Comparing base (12d8f1c) to head (a65908c).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...tity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java 29.41% 10 Missing and 2 partials ⚠️
...bon/identity/oauth/endpoint/util/EndpointUtil.java 37.50% 9 Missing and 1 partial ⚠️
...ity/oauth2/rar/util/AuthorizationDetailsUtils.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2675      +/-   ##
============================================
- Coverage     55.65%   55.59%   -0.07%     
+ Complexity     8524     8390     -134     
============================================
  Files           645      644       -1     
  Lines         49283    48428     -855     
  Branches       9535     9606      +71     
============================================
- Hits          27429    26923     -506     
+ Misses        17960    17674     -286     
+ Partials       3894     3831      -63
Flag Coverage Δ
unit 39.50% <45.45%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12822396715
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12824946667

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12824946667
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12825653251

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12825653251
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12901139471

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12901139471
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12908577299

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12908577299
Status: failure

@lashinijay lashinijay force-pushed the master-oauth2-revamp branch from 549c365 to d9427b7 Compare January 22, 2025 13:20
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12909137337

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12909137337
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 22, 2025
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12909137337

nilasini
nilasini previously approved these changes Jan 23, 2025
View reviewed changes
@lashinijay lashinijay force-pushed the master-oauth2-revamp branch from 6d5f8eb to fffc1a6 Compare January 23, 2025 11:32
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12928295136

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12928295136
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12928429258

nilasini
nilasini previously approved these changes Jan 23, 2025
View reviewed changes
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12928429258
Status: failure

@lashinijay lashinijay force-pushed the master-oauth2-revamp branch from 159c7c6 to 728b8e7 Compare January 23, 2025 12:16
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12932303624

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12932303624
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 23, 2025
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12932303624

@lashinijay lashinijay merged commit c2f0adf into wso2-extensions:master Jan 23, 2025
3 of 4 checks passed
@VimukthiRajapaksha VimukthiRajapaksha mentioned this pull request Jan 25, 2025
Closed
@lashinijay lashinijay mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@sahandilshan sahandilshan sahandilshan approved these changes

@nilasini nilasini nilasini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lashinijay @jenkins-is-staging @nilasini @sahandilshan